Landings for Stack Containing D192322

Failed to land

Landing requested on , by dmeehan@mozilla.com.

Revisions: D192322 diff 781493

While applying revision D192322 to release, the following files had conflicts:

(Hint: try rebasing your changes on the latest commits from release and re-submitting.)

  • dom/html/HTMLInputElement.cpp @ 1523cba1148727e007ce7624ace9020d3442b1b3
  • --- HTMLInputElement.cpp
    +++ HTMLInputElement.cpp
    ...
    
    --- HTMLInputElement.cpp
    +++ HTMLInputElement.cpp
    @@ -6273,10 +6272,13 @@
         // should not be that common an occurrence, I think we can live with
         // that.
         // Make sure not to notify if we're still being created.
         //
         RadioSetChecked(mDoneCreating);
    +  } else {
    +    bool indeterminate = !container->GetCurrentRadioButton(name);
    +    SetStates(ElementState::INDETERMINATE, indeterminate, mDoneCreating);
       }
     
       //
       // For integrity purposes, we have to ensure that "checkedChanged" is
       // the same for this new element as for all the others in the group
    
Raw error output:
Problem while applying patch in revision 192322:

hg error in cmd: hg import --no-commit -s 95 /tmp/tmp02nju46t: applying /tmp/tmp02nju46t

patching file dom/html/HTMLInputElement.cpp
Hunk #2 FAILED at 6271
1 out of 3 hunks FAILED -- saving rejects to file dom/html/HTMLInputElement.cpp.rej
abort: patch failed to apply

Stack containing revision D192322

Land Bug Status Revision Reviewers
1861346
Blocked
Revision is closed.
Abandoned
D192322: Bug 1861346 - Update indeterminate state when getting added or removed from a radio group. r=edgar,smaug
  • @release-managers requested changes (Blocks Landing)
  • @emilio to review