Landings for Stack Containing D211241

Failed to land

Landing requested on , by pchevrel@mozilla.com.

Revisions: D211241 diff 865652

While applying revision D211241 to beta, the following files had conflicts:

(Hint: try rebasing your changes on the latest commits from beta and re-submitting.)

  • js/src/vm/StringType.cpp @ 646fe555b999abb4af5a400002fe9f06410c9dd8
  • --- StringType.cpp
    +++ StringType.cpp
    ...
    
    --- StringType.cpp
    +++ StringType.cpp
    @@ -1513,10 +1513,12 @@
       Rooted<JSLinearString*> linearString(cx, s->ensureLinear(cx));
       if (!linearString) {
         return false;
       }
     
    +  linearString->setDependedOn();
    +
       MOZ_ASSERT(state_ == Uninitialized);
     
       // Inline and nursery-allocated chars may move during a GC, so copy them
       // out into a temporary malloced buffer. Note that we cannot update the
       // string itself with a malloced buffer, because there may be dependent
    @@ -1544,10 +1546,12 @@
       Rooted<JSLinearString*> linearString(cx, s->ensureLinear(cx));
       if (!linearString) {
         return false;
       }
     
    +  linearString->setDependedOn();
    +
       MOZ_ASSERT(state_ == Uninitialized);
     
       if (linearString->hasLatin1Chars()) {
         return copyAndInflateLatin1Chars(cx, linearString);
       }
    
Raw error output:
Problem while applying patch in revision 211241:

hg error in cmd: hg import --no-commit -s 95 /tmp/tmptpe_iyja: applying /tmp/tmptpe_iyja

patching file js/src/vm/StringType.cpp
Hunk #1 FAILED at 1512
Hunk #2 FAILED at 1543
2 out of 2 hunks FAILED -- saving rejects to file js/src/vm/StringType.cpp.rej
abort: patch failed to apply

Stack containing revision D211241

Land Bug Status Revision Reviewers
1894428
Blocked
Repository is not supported by Lando.
Closed
D211241: Bug 1894428 - Set depended on bit from AutoStableStringChars r?sfink
  • @release-managers accepted a prior diff
  • @pascalc accepted a prior diff